[Harbour] SF.net SVN: harbour-project:[14029] trunk/harbour

[Xavi]

Hi Viktor,

> Please revert this. The behavior was intentionally
> designed to be controlled by hb_GTInfo( HB_GTI_CLOSABLE ),
> (instead of SETCANCEL()).

Sorry but as you've seen the development list has been off-line many hours.
You've done a reversal before I can read the messages.

Could you explain what is the intention of change because .-

2008-06-25 11:49 UTC+0200 Viktor Szakats (harbour.01 syenar.hu)
    * source/rtl/gtwvt/gtwvt.c
      * Slightly changed the way CLOSE button works.
        Now the close button, if enabled, will always
        force a shutdown. So this setting is made independent
        of SetCancel(). I choose this because there might
        be cases when we need to use <Alt+C> in app code, yet
        we want to allow closing the window. Previously it was
        also easy to create confusing scenarios by using various
        combinations of HB_GTI_CLOSABLE + SetCancel(). Another
        kind of fix - without the advantage above - would be
        to fully sync SetCancel() with HB_GTI_CLOSABLE.

It's very unclear and before the change SetCancel() was respected.

You say: "I choose this because there might be cases when we need to use <Alt+C> in app code, yet we want to allow closing the 
window."

Sorry but I don't understand. You change the behavior of GTWVT with SetCancel() respect to GTWIN and GTWVG for something that 
you can do in your code with .-

hb_gtInfo( HB_GTI_NOTIFIERBLOCK, {|e| iif( e == HB_GTE_CLOSE, SetCancel(.T.), nil ), 0} )

Best regards,
-- 
Xavi

El 01/03/2010 9:32, Viktor Szakáts escribió:
> Hi Xavi,
>
> Please revert this. The behavior was intentionally
> designed to be controlled by hb_GTInfo( HB_GTI_CLOSABLE ),
> (instead of SETCANCEL()).
>
> Brgds,
> Viktor
>
> On 2010 Mar 1, at 04:06, jarabal at users.sourceforge.net wrote:
>
>> Revision: 14029
>>           http://harbour-project.svn.sourceforge.net/harbour-project/?rev=14029&view=rev
>> Author:   jarabal
>> Date:     2010-03-01 03:06:26 +0000 (Mon, 01 Mar 2010)
>>
>> Log Message:
>> -----------
>> 2010-03-01 04:05 UTC+0100 Xavi (jarabal/at/gmail.com)
>>   * harbour/src/rtl/gtwvt/gtwvt.c
>>     ! Fixing WM_CLOSE event (Clicked 'X' on system menu)
>>       to avoid irregular shutdown with SETCANCEL( .F. )
>>
>>       REQUEST HB_GT_WVT_DEFAULT
>>       ANNOUNCE HB_GTSYS
>>       PROCEDURE Main()
>>          SetCancel(.F.)
>>          ? "Click [X] Not close windows"
>>          while( LastKey() != 27 )
>>             Inkey( 1 )
>>          enddo
>>       RETURN
>>
>> Modified Paths:
>> --------------
>>     trunk/harbour/ChangeLog
>>     trunk/harbour/src/rtl/gtwvt/gtwvt.c
>>
>>
>> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>> _______________________________________________
>> Harbour mailing list (attachment size limit: 40KB)
>> Harbour at harbour-project.org
>> http://lists.harbour-project.org/mailman/listinfo/harbour
>